Skip to content

Unit test failing: tests/unit/test_config.py::test_env_config_not_defined_does_not_raise #1764

Closed

Description

@JohnVillalovos

Unit test appears to be picking up local file.


mock_clean_env = None

    def test_env_config_not_defined_does_not_raise(mock_clean_env):
>       assert config._get_config_files() == []
E       AssertionError: assert ['/home/jlvil...n-gitlab.cfg'] == []
E         Left contains one more item: '/home/jlvillal/.python-gitlab.cfg'
E         Full diff:
E         - []
E         + ['/home/jlvillal/.python-gitlab.cfg']

tests/unit/test_config.py:130: AssertionError
=============================================================================================================================== short test summary info ===============================================================================================================================
FAILED tests/unit/test_config.py::test_env_config_not_defined_does_not_raise - AssertionError: assert ['/home/jlvil...n-gitlab.cfg'] == []
====================================================================================================================== 1 failed, 687 passed, 33 skipped in 2.12s ======================================================================================================================
ERROR: InvocationError for command /home/jlvillal/sources/github-mine/python-gitlab/.tox/py310/bin/pytest tests/unit tests/meta -v (exited with code 1)

Activity

  1. JohnVillalovos commented on Dec 19, 2021

    @JohnVillalovos
    MemberAuthor

    @nejch Not sure if you have seen this or not.

  2. JohnVillalovos commented on Dec 19, 2021

    @JohnVillalovos
    MemberAuthor

    I did a git bisect and this was the bad commit:

    commit 92a893b8e230718436582dcad96175685425b1df
    Author: Nejc Habjan <hab.nejc@gmail.com>
    Date:   Sun Dec 12 19:19:45 2021 +0100
    
        feat(cli): do not require config file to run CLI
    
        BREAKING CHANGE: A config file is no longer needed to run
        the CLI. python-gitlab will default to https://gitlab.com
        with no authentication if there is no config file provided.
        python-gitlab will now also only look for configuration
        in the provided PYTHON_GITLAB_CFG path, instead of merging
        it with user- and system-wide config files. If the
        environment variable is defined and the file cannot be
        opened, python-gitlab will now explicitly fail.
    
  3. changed the title [-]Unit test failing[/-] [+]Unit test failing: tests/unit/test_config.py::test_env_config_not_defined_does_not_raise[/+] on Dec 19, 2021
  4. added a commit that references this issue on Dec 19, 2021
    c80b3b7
  5. locked as resolved and limited conversation to collaborators on Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions