Api return 404 when keyword contains point symbol

if the branch/commit keyword contains point symbol . , the api will return 404 response

example:
project.branches.get('stbale-1.x')
project.comits.get('stbale-1.x')

In page: gl_objects/projects.rst

Can you run the following and provide the output?

#!/usr/bin/env python3

import gitlab
print("gitlab version:", gitlab.__version__)
print("gitlab location:", gitlab.__file__)

As a note, to help your debugging you can do the following, if you want:

import gitlab

gl = gitlab.Gitlab(... your values ...)
gl.enable_debug()

version: '2.10.1'
file: '/Users/insoz/code/ops-fast/venv/lib/python3.7/site-packages/gitlab/init.py'

Thanks. I have a suspicion it is because of:

python-gitlab/gitlab/utils.py

Line 65 in 3225f2c

new_path = parsed.path.replace(".", "%2E")

But not sure if we can just take that out or not. We really need to move to using urllib.parse.quote() for this stuff. Though requests does some it self and I haven't dug into exactly what we are responsible for and what requests will take care of.

Related issue: #1356

Thanks! BTW. Do we have some plan to use httpx or something asyncio tool to asynchronous this lib ?

Thanks! BTW. Do we have some plan to use httpx or something asyncio tool to asynchronous this lib ?

Yes, httpx probably, though it still hasn't reached 1.0 and last I checked was missing some proxy or retry features or so, if I'm not mistaken, can't quite remember.
But there is an old PR here that already uses it if you really need it (likely missing lots of recent features): #1036. That'll need some major rework to update though once we're ready.

@JohnVillalovos

@JohnVillalovos wasn't this fixed by 702e41d? If so we can close it, unless you'd like to add a test for that.

chore: add test case to branch name with period works

chore: add test case to show branch name with period works

@JohnVillalovos

@JohnVillalovos wasn't this fixed by 702e41d? If so we can close it, unless you'd like to add a test for that.

It was. I just added PR #1800 to prove it works

Navigation Menu

Repository navigation

Api return 404 when keyword contains point symbol #1715

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Api return 404 when keyword contains point symbol #1715

Description

Activity

JohnVillalovos commented on Nov 26, 2021

JohnVillalovos commented on Nov 26, 2021

insoz commented on Nov 26, 2021

JohnVillalovos commented on Nov 26, 2021

JohnVillalovos commented on Nov 26, 2021

insoz commented on Nov 26, 2021

nejch commented on Nov 26, 2021

nejch commented on Jan 4, 2022

JohnVillalovos commented on Jan 4, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions