Add ban/unban and approve/reject methods to User #1604

Activity

1. sathieu

   changed the title [-]Add ban/unaban and approve/reject methods to User[/-] [+]Add ban/unban and approve/reject methods to User[/+] on Oct 13, 2021
2. bgamari

   added 5 commits that reference this issue on Jun 9, 2022

   feat(users): Add approve and reject methods to User

   ...

   9690d38

   feat(users): Add approve and reject methods to User

   ...

   c4db40c

   feat(users): Add approve and reject methods to User

   ...

   b6b33b6

   feat(users): Add approve and reject methods to User

   ...

   26a62e1

   feat(users): Add approve and reject methods to User

   ...

   7e78eb8
3. nejch commented on Jun 10, 2022

   

   nejch

   on Jun 10, 2022

   Member

   More actions

   @antoineauger as discussed if you want a break from k8s and work on this 😁

   There's a PR that implements approve/reject endpoints for this issue in #2061 - you could do the same for ban/unban:
   https://docs.gitlab.com/ee/api/users.html#ban-user
   https://docs.gitlab.com/ee/api/users.html#unban-user

   See my comments in the other PR for a bit of guidance, although ideally we'd also have 1 response per mock and 1 assert per test so we can remove assert_all_requests_are_fired=False.

   In the case of ban/unban I think we could also add a quick functional test like for block/unblock. https://github.com/python-gitlab/python-gitlab/blob/main/tests/functional/api/test_users.py#L30-L37.

   With both PRs in we could then close this issue. Of course if there's any hiccups along the way I'm happy to look at docs PRs as well if you feel like it 😀

   👍React with 👍1Reacted by Antoine Auger
4. nejch

   added a commit that references this issue on Jun 25, 2022

   feat(users): add approve and reject methods to User

   ...

   f57139d
5. nejch

   closed this as completedin #2061on Jun 25, 2022
6. github-actions

   locked as resolved and limited conversation to collaborators on Jun 26, 2023