Repository navigation
Pagination broken on ProjectIssues #140
Description
Only the first page is returned regardless of the value of page parameter. The per_page param also is ignored.
>>> gl = gitlab.Gitlab(gitlab_url, gitlab_secret)
>>> proj = gl.projects.get(project)
>>> [x.iid for x in proj.issues.list(page=1)]
[237, 236, 235, 234, 233, 232, 231, 230, 229, 228, 227, 226, 225, 224, 223, 222, 221, 220, 219, 218]
>>> [x.iid for x in proj.issues.list(page=2)]
[237, 236, 235, 234, 233, 232, 231, 230, 229, 228, 227, 226, 225, 224, 223, 222, 221, 220, 219, 218]
>>> [x.iid for x in proj.issues.list(page=1, per_page=5)]
[237, 236, 235, 234, 233, 232, 231, 230, 229, 228, 227, 226, 225, 224, 223, 222, 221, 220, 219, 218]
It appears that Gitlab.list() boils down to the following:
url = self._construct_url(id_=None, obj=obj_class, parameters=kwargs)
return self._raw_list(url, obj_class, **kwargs)
In _raw_list, pagination params are stripped from the query:
for key in ['all', 'page', 'per_page', 'sudo', 'next_url']:
if key in params:
del params[key]
Activity
gpocentek commentedon Sep 3, 2016
_raw_list() is indeed broken, thanks for the report.
gpocentek commentedon Sep 3, 2016
Could you test the master branch and tell me if it works fine for you now? I'll prepare a new release if it's OK. Thanks.
tmick0 commentedon Sep 3, 2016
Looks like it works
Thanks for the fix
gpocentek commentedon Sep 3, 2016
Thanks for your feedback. I'll push a 0.15.1 soon.