style: recommended changes in PR review

walterrowe · walterrowe · commit f98fd9096791 · 2022-05-31T12:37:58.000-04:00
diff --git a/gitlab/mixins.py b/gitlab/mixins.py
@@ -342,10 +342,9 @@ def update(
         else:
             path = f"{self.path}/{utils.EncodedId(id)}"
 
-        if self._obj_cls is not None:
+        excludes = []
+        if self._obj_cls is not None and self._obj_cls._id_attr is not None:
             excludes = [self._obj_cls._id_attr]
-        else:
-            excludes = None
         utils._validate_attrs(
             data=new_data, attributes=self._update_attrs, excludes=excludes
         )
diff --git a/gitlab/utils.py b/gitlab/utils.py
@@ -19,7 +19,7 @@
 import traceback
 import urllib.parse
 import warnings
-from typing import Any, Callable, Dict, Optional, Tuple, Type, Union
+from typing import Any, Callable, Dict, List, Optional, Tuple, Type, Union
 
 import requests
 
@@ -166,7 +166,7 @@ def warn(
 def _validate_attrs(
     data: Dict[str, Any],
     attributes: types.RequiredOptional,
-    excludes: Optional[list] = None,
+    excludes: Optional[List[str]] = None,
 ) -> None:
     if excludes is None:
         excludes = []
