feat(objects): support all issues statistics endpoints

nejch · JohnVillalovos · commit f731707f0762 · 2021-05-30T08:50:09.000-07:00
diff --git a/docs/gl_objects/issues.rst b/docs/gl_objects/issues.rst
@@ -225,3 +225,51 @@ Link issue ``i1`` to issue ``i2``::
 Delete a link::
 
     i1.links.delete(issue_link_id)
+
+Issues statistics
+=========================
+
+Reference
+---------
+
+* v4 API:
+
+  + :class:`gitlab.v4.objects.IssuesStatistics`
+  + :class:`gitlab.v4.objects.IssuesStatisticsManager`
+  + :attr:`gitlab.issuesstatistics`
+  + :class:`gitlab.v4.objects.GroupIssuesStatistics`
+  + :class:`gitlab.v4.objects.GroupIssuesStatisticsManager`
+  + :attr:`gitlab.v4.objects.Group.issuesstatistics`
+  + :class:`gitlab.v4.objects.ProjectIssuesStatistics`
+  + :class:`gitlab.v4.objects.ProjectIssuesStatisticsManager`
+  + :attr:`gitlab.v4.objects.Project.issuesstatistics`
+
+
+* GitLab API: https://docs.gitlab.com/ce/api/issues_statistics.htm
+
+Examples
+---------
+
+Get statistics of all issues the user has access to::
+
+    statistics = gl.issuesstatistics.get()
+
+Get statistics of issues for the user with ``foobar`` in ``title`` and ``description``::
+
+    statistics = gl.issuesstatistics.get(search='foobar')
+
+Get statistics of all issues in a group::
+
+    statistics = group.issuesstatistics.get()
+
+Get statistics of issues in a group with ``foobar`` in ``title`` and ``description``::
+
+    statistics = group.issuesstatistics.get(search='foobar')
+
+Get statistics of all issues in a project::
+
+    statistics = project.issuesstatistics.get()
+
+Get statistics of issues in a project with ``foobar`` in ``title`` and ``description``::
+
+    statistics = project.issuesstatistics.get(search='foobar')
diff --git a/docs/gl_objects/projects.rst b/docs/gl_objects/projects.rst
@@ -768,29 +768,3 @@ Get all additional statistics of a project::
 Get total fetches in last 30 days of a project::
 
     total_fetches = project.additionalstatistics.get().fetches['total']
-
-Project issues statistics
-=========================
-
-Reference
----------
-
-* v4 API:
-
-  + :class:`gitlab.v4.objects.ProjectIssuesStatistics`
-  + :class:`gitlab.v4.objects.ProjectIssuesStatisticsManager`
-  + :attr:`gitlab.v4.objects.Project.issuesstatistics`
-
-* GitLab API: https://docs.gitlab.com/ce/api/issues_statistics.html#get-project-issues-statistics
-
-Examples
----------
-
-Get statistics of all issues in a project::
-
-    statistics = project.issuesstatistics.get()
-
-Get statistics of issues in a project with ``foobar`` in ``title`` and
-``description``::
-
-    statistics = project.issuesstatistics.get(search='foobar')
diff --git a/gitlab/client.py b/gitlab/client.py
@@ -118,6 +118,7 @@ def __init__(
         self.groups = objects.GroupManager(self)
         self.hooks = objects.HookManager(self)
         self.issues = objects.IssueManager(self)
+        self.issuesstatistics = objects.IssuesStatisticsManager(self)
         self.ldapgroups = objects.LDAPGroupManager(self)
         self.licenses = objects.LicenseManager(self)
         self.namespaces = objects.NamespaceManager(self)
diff --git a/gitlab/v4/objects/groups.py b/gitlab/v4/objects/groups.py
@@ -26,6 +26,7 @@
 from .packages import GroupPackageManager  # noqa: F401
 from .projects import GroupProjectManager  # noqa: F401
 from .runners import GroupRunnerManager  # noqa: F401
+from .statistics import GroupIssuesStatisticsManager  # noqa: F401
 from .variables import GroupVariableManager  # noqa: F401
 
 __all__ = [
@@ -52,6 +53,7 @@ class Group(SaveMixin, ObjectDeleteMixin, RESTObject):
         ("epics", "GroupEpicManager"),
         ("imports", "GroupImportManager"),
         ("issues", "GroupIssueManager"),
+        ("issuesstatistics", "GroupIssuesStatisticsManager"),
         ("labels", "GroupLabelManager"),
         ("members", "GroupMemberManager"),
         ("members_all", "GroupMemberAllManager"),
diff --git a/gitlab/v4/objects/statistics.py b/gitlab/v4/objects/statistics.py
@@ -2,8 +2,12 @@
 from gitlab.mixins import GetWithoutIdMixin, RefreshMixin
 
 __all__ = [
+    "GroupIssuesStatistics",
+    "GroupIssuesStatisticsManager",
     "ProjectAdditionalStatistics",
     "ProjectAdditionalStatisticsManager",
+    "IssuesStatistics",
+    "IssuesStatisticsManager",
     "ProjectIssuesStatistics",
     "ProjectIssuesStatisticsManager",
 ]
@@ -19,6 +23,25 @@ class ProjectAdditionalStatisticsManager(GetWithoutIdMixin, RESTManager):
     _from_parent_attrs = {"project_id": "id"}
 
 
+class IssuesStatistics(RefreshMixin, RESTObject):
+    _id_attr = None
+
+
+class IssuesStatisticsManager(GetWithoutIdMixin, RESTManager):
+    _path = "/issues_statistics"
+    _obj_cls = IssuesStatistics
+
+
+class GroupIssuesStatistics(RefreshMixin, RESTObject):
+    _id_attr = None
+
+
+class GroupIssuesStatisticsManager(GetWithoutIdMixin, RESTManager):
+    _path = "/groups/%(group_id)s/issues_statistics"
+    _obj_cls = GroupIssuesStatistics
+    _from_parent_attrs = {"group_id": "id"}
+
+
 class ProjectIssuesStatistics(RefreshMixin, RESTObject):
     _id_attr = None
 
diff --git a/tests/unit/objects/test_issues.py b/tests/unit/objects/test_issues.py
@@ -1,11 +1,16 @@
 """
 GitLab API: https://docs.gitlab.com/ce/api/issues.html
 """
+import re
 
 import pytest
 import responses
 
-from gitlab.v4.objects import ProjectIssuesStatistics
+from gitlab.v4.objects import (
+    GroupIssuesStatistics,
+    IssuesStatistics,
+    ProjectIssuesStatistics,
+)
 
 
 @pytest.fixture
@@ -43,7 +48,9 @@ def resp_issue_statistics():
     with responses.RequestsMock() as rsps:
         rsps.add(
             method=responses.GET,
-            url="http://localhost/api/v4/projects/1/issues_statistics",
+            url=re.compile(
+                r"http://localhost/api/v4/((groups|projects)/1/)?issues_statistics"
+            ),
             json=content,
             content_type="application/json",
             status=200,
@@ -63,7 +70,19 @@ def test_get_issue(gl, resp_get_issue):
     assert issue.name == "name"
 
 
-def test_project_issues_statistics(project, resp_issue_statistics):
+def test_get_issues_statistics(gl, resp_issue_statistics):
+    statistics = gl.issuesstatistics.get()
+    assert isinstance(statistics, IssuesStatistics)
+    assert statistics.statistics["counts"]["all"] == 20
+
+
+def test_get_group_issues_statistics(group, resp_issue_statistics):
+    statistics = group.issuesstatistics.get()
+    assert isinstance(statistics, GroupIssuesStatistics)
+    assert statistics.statistics["counts"]["all"] == 20
+
+
+def test_get_project_issues_statistics(project, resp_issue_statistics):
     statistics = project.issuesstatistics.get()
     assert isinstance(statistics, ProjectIssuesStatistics)
     assert statistics.statistics["counts"]["all"] == 20
