fix: remove default arguments for mergerequests.merge()

JohnVillalovos · JohnVillalovos · commit d76152e5d337 · 2022-01-08T14:47:20.000-08:00
The arguments `should_remove_source_branch` and `merge_when_pipeline_succeeds` are optional arguments. We should not be setting any default value for them. https://docs.gitlab.com/ee/api/merge_requests.html#accept-mr Closes: #1750
diff --git a/gitlab/v4/objects/merge_requests.py b/gitlab/v4/objects/merge_requests.py
@@ -358,8 +358,8 @@ def merge_ref(self, **kwargs: Any) -> Union[Dict[str, Any], requests.Response]:
     def merge(
         self,
         merge_commit_message: Optional[str] = None,
-        should_remove_source_branch: bool = False,
-        merge_when_pipeline_succeeds: bool = False,
+        should_remove_source_branch: Optional[bool] = None,
+        merge_when_pipeline_succeeds: Optional[bool] = None,
         **kwargs: Any,
     ) -> Dict[str, Any]:
         """Accept the merge request.
@@ -382,8 +382,8 @@ def merge(
             data["merge_commit_message"] = merge_commit_message
         if should_remove_source_branch is not None:
             data["should_remove_source_branch"] = should_remove_source_branch
-        if merge_when_pipeline_succeeds:
-            data["merge_when_pipeline_succeeds"] = True
+        if merge_when_pipeline_succeeds is not None:
+            data["merge_when_pipeline_succeeds"] = merge_when_pipeline_succeeds
 
         server_data = self.manager.gitlab.http_put(path, post_data=data, **kwargs)
         if TYPE_CHECKING:
