Skip to content

Commit d47e03f

Browse files
committed
fixup! feat(api): add 'masked_and_hidden' to the optional variable create attrs
add missing optional attributes
1 parent 4ea4cc0 commit d47e03f

1 file changed

Lines changed: 44 additions & 8 deletions

File tree

gitlab/v4/objects/variables.py

Lines changed: 44 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,19 @@ class VariableManager(CRUDMixin[Variable]):
2727
_path = "/admin/ci/variables"
2828
_obj_cls = Variable
2929
_create_attrs = RequiredOptional(
30-
required=("key", "value"), optional=("protected", "variable_type", "masked")
30+
required=("key", "value"),
31+
optional=("description", "masked", "protected", "raw", "variable_type"),
3132
)
3233
_update_attrs = RequiredOptional(
33-
required=("key",), optional=("value", "protected", "variable_type", "masked")
34+
required=("key",),
35+
optional=(
36+
"description",
37+
"masked",
38+
"protected",
39+
"raw",
40+
"value",
41+
"variable_type",
42+
),
3443
)
3544

3645

@@ -44,10 +53,27 @@ class GroupVariableManager(CRUDMixin[GroupVariable]):
4453
_from_parent_attrs = {"group_id": "id"}
4554
_create_attrs = RequiredOptional(
4655
required=("key", "value"),
47-
optional=("protected", "variable_type", "masked", "masked_and_hidden"),
56+
optional=(
57+
"description",
58+
"environment_scope",
59+
"masked",
60+
"masked_and_hidden",
61+
"protected",
62+
"raw",
63+
"variable_type",
64+
),
4865
)
4966
_update_attrs = RequiredOptional(
50-
required=("key",), optional=("value", "protected", "variable_type", "masked")
67+
required=("key",),
68+
optional=(
69+
"description",
70+
"environment_scope",
71+
"masked",
72+
"protected",
73+
"raw",
74+
"value",
75+
"variable_type",
76+
),
5177
)
5278

5379

@@ -62,14 +88,24 @@ class ProjectVariableManager(CRUDMixin[ProjectVariable]):
6288
_create_attrs = RequiredOptional(
6389
required=("key", "value"),
6490
optional=(
65-
"protected",
66-
"variable_type",
67-
"masked",
91+
"description",
6892
"environment_scope",
93+
"masked",
6994
"masked_and_hidden",
95+
"protected",
96+
"raw",
97+
"variable_type",
7098
),
7199
)
72100
_update_attrs = RequiredOptional(
73101
required=("key",),
74-
optional=("value", "protected", "variable_type", "masked", "environment_scope"),
102+
optional=(
103+
"description",
104+
"environment_scope",
105+
"masked",
106+
"protected",
107+
"raw",
108+
"value",
109+
"variable_type",
110+
),
75111
)

0 commit comments

Comments
 (0)