fix(objects): rename confusing to_project_id argument

nejch · JohnVillalovos · commit ce4bc0daef35 · 2021-09-11T09:17:18.000-07:00
BREAKING CHANGE: rename confusing `to_project_id` argument in transfer_project
to `project_id` (`--project-id` in CLI). This is used for the source project,
not for the target namespace.
diff --git a/gitlab/v4/objects/groups.py b/gitlab/v4/objects/groups.py
@@ -72,9 +72,9 @@ class Group(SaveMixin, ObjectDeleteMixin, RESTObject):
     variables: GroupVariableManager
     wikis: GroupWikiManager
 
-    @cli.register_custom_action("Group", ("to_project_id",))
+    @cli.register_custom_action("Group", ("project_id",))
     @exc.on_http_error(exc.GitlabTransferProjectError)
-    def transfer_project(self, to_project_id, **kwargs):
+    def transfer_project(self, project_id, **kwargs):
         """Transfer a project to this group.
 
         Args:
@@ -85,7 +85,7 @@ def transfer_project(self, to_project_id, **kwargs):
             GitlabAuthenticationError: If authentication is not correct
             GitlabTransferProjectError: If the project could not be transfered
         """
-        path = "/groups/%s/projects/%s" % (self.id, to_project_id)
+        path = "/groups/%s/projects/%s" % (self.id, project_id)
         self.manager.gitlab.http_post(path, **kwargs)
 
     @cli.register_custom_action("Group", ("scope", "search"))
