Add 'search' attribute to projects.list()

Gauvain Pocentek · Gauvain Pocentek · commit ce3dd0d1ac3f · 2017-05-23T15:38:41.000+02:00
projects.search() has been deprecated by Gitlab
diff --git a/docs/gl_objects/projects.py b/docs/gl_objects/projects.py
@@ -16,7 +16,7 @@
 projects = gl.projects.all()
 
 # Search projects
-projects = gl.projects.search('query')
+projects = gl.projects.list(search='query')
 # end list
 
 # get
diff --git a/gitlab/objects.py b/gitlab/objects.py
@@ -2276,6 +2276,7 @@ class ProjectRunnerManager(BaseManager):
 class Project(GitlabObject):
     _url = '/projects'
     _constructorTypes = {'owner': 'User', 'namespace': 'Group'}
+    optionalListAttrs = ['search']
     requiredCreateAttrs = ['name']
     optionalCreateAttrs = ['path', 'namespace_id', 'description',
                            'issues_enabled', 'merge_requests_enabled',
diff --git a/gitlab/tests/test_manager.py b/gitlab/tests/test_manager.py
@@ -215,8 +215,8 @@ def resp_get_all(url, request):
     def test_project_manager_search(self):
         mgr = ProjectManager(self.gitlab)
 
-        @urlmatch(scheme="http", netloc="localhost",
-                  path="/api/v3/projects/search/foo", method="get")
+        @urlmatch(scheme="http", netloc="localhost", path="/api/v3/projects",
+                  query="search=foo", method="get")
         def resp_get_all(url, request):
             headers = {'content-type': 'application/json'}
             content = ('[{"name": "foo1", "id": 1}, '
@@ -225,7 +225,7 @@ def resp_get_all(url, request):
             return response(200, content, headers, None, 5, request)
 
         with HTTMock(resp_get_all):
-            data = mgr.search('foo')
+            data = mgr.list(search='foo')
             self.assertEqual(type(data), list)
             self.assertEqual(2, len(data))
             self.assertEqual(type(data[0]), Project)
diff --git a/tools/python_test.py b/tools/python_test.py
@@ -145,7 +145,7 @@
 
 assert(len(gl.projects.all()) == 4)
 assert(len(gl.projects.owned()) == 2)
-assert(len(gl.projects.search("admin")) == 1)
+assert(len(gl.projects.list(search="admin")) == 1)
 
 # test pagination
 l1 = gl.projects.list(per_page=1, page=1)
