skip BaseManager attributes when encoding to JSON

rhansen · rhansen · commit ca6da62010ee · 2016-01-23T03:57:12.000-05:00
This fixes the following exception when calling User.json():

    TypeError: &lt;gitlab.objects.UserKeyManager object at 0x7f0477391ed0&gt; is not JSON serializable
diff --git a/gitlab/objects.py b/gitlab/objects.py
@@ -33,7 +33,8 @@ class jsonEncoder(json.JSONEncoder):
     def default(self, obj):
         from gitlab import Gitlab
         if isinstance(obj, GitlabObject):
-            return obj.__dict__
+            return {k: v for k, v in obj.__dict__.iteritems()
+                    if not isinstance(v, BaseManager)}
         elif isinstance(obj, Gitlab):
             return {'url': obj._url}
         return json.JSONEncoder.default(self, obj)
@@ -475,7 +476,7 @@ def json(self):
         Returns:
             str: The json string.
         """
-        return json.dumps(self.__dict__, cls=jsonEncoder)
+        return json.dumps(self, cls=jsonEncoder)
 
 
 class UserKey(GitlabObject):
