Merge pull request #2332 from python-gitlab/jlvillal/fix_test

nejch · web-flow · commit c676b43dc4a5 · 2022-10-19T18:25:35.000+02:00
test: fix `test_project_push_rules` test
diff --git a/tests/functional/api/test_push_rules.py b/tests/functional/api/test_push_rules.py
@@ -1,11 +1,14 @@
 import pytest
 
+import gitlab
+
 
 @pytest.mark.gitlab_premium
-@pytest.mark.xfail(reason="need to relax RESTObject init for non-dict responses")
 def test_project_push_rules(project):
-    push_rules = project.pushrules.get()
-    assert not push_rules
+    with pytest.raises(gitlab.GitlabParsingError):
+        # when no rules are defined the API call returns back `None` which
+        # causes a gitlab.GitlabParsingError in RESTObject.__init__()
+        project.pushrules.get()
 
     push_rules = project.pushrules.create({"deny_delete_tag": True})
     assert push_rules.deny_delete_tag
@@ -18,4 +21,6 @@ def test_project_push_rules(project):
     assert not push_rules.deny_delete_tag
 
     push_rules.delete()
-    assert not push_rules
+
+    with pytest.raises(gitlab.GitlabParsingError):
+        project.pushrules.get()
