test: convert usage of match_querystring to match

JohnVillalovos · JohnVillalovos · commit c5a4ab6e0552 · 2022-01-15T15:52:27.000-08:00
In the `responses` library the usage of `match_querystring` is
deprecated. Convert to using `match`
diff --git a/tests/unit/mixins/test_mixin_methods.py b/tests/unit/mixins/test_mixin_methods.py
@@ -35,7 +35,7 @@ class M(GetMixin, FakeManager):
         url=url,
         json={"id": 42, "foo": "bar"},
         status=200,
-        match_querystring=True,
+        match=[responses.matchers.query_param_matcher({})],
     )
 
     mgr = M(gl)
@@ -57,7 +57,7 @@ class TestClass(RefreshMixin, FakeObject):
         url=url,
         json={"id": 42, "foo": "bar"},
         status=200,
-        match_querystring=True,
+        match=[responses.matchers.query_param_matcher({})],
     )
 
     mgr = FakeManager(gl)
@@ -80,7 +80,7 @@ class M(GetWithoutIdMixin, FakeManager):
         url=url,
         json={"foo": "bar"},
         status=200,
-        match_querystring=True,
+        match=[responses.matchers.query_param_matcher({})],
     )
 
     mgr = M(gl)
@@ -102,7 +102,7 @@ class M(ListMixin, FakeManager):
         url=url,
         json=[{"id": 42, "foo": "bar"}, {"id": 43, "foo": "baz"}],
         status=200,
-        match_querystring=True,
+        match=[responses.matchers.query_param_matcher({})],
     )
 
     # test RESTObjectList
@@ -134,7 +134,7 @@ class M(ListMixin, FakeManager):
         url=url,
         json=[{"id": 42, "foo": "bar"}],
         status=200,
-        match_querystring=True,
+        match=[responses.matchers.query_param_matcher({})],
     )
 
     mgr = M(gl)
@@ -177,7 +177,7 @@ class M(CreateMixin, FakeManager):
         url=url,
         json={"id": 42, "foo": "bar"},
         status=200,
-        match_querystring=True,
+        match=[responses.matchers.query_param_matcher({})],
     )
 
     mgr = M(gl)
@@ -202,7 +202,7 @@ class M(CreateMixin, FakeManager):
         url=url,
         json={"id": 42, "foo": "bar"},
         status=200,
-        match_querystring=True,
+        match=[responses.matchers.query_param_matcher({})],
     )
 
     mgr = M(gl)
@@ -243,7 +243,7 @@ class M(UpdateMixin, FakeManager):
         url=url,
         json={"id": 42, "foo": "baz"},
         status=200,
-        match_querystring=True,
+        match=[responses.matchers.query_param_matcher({})],
     )
 
     mgr = M(gl)
@@ -268,7 +268,7 @@ class M(UpdateMixin, FakeManager):
         url=url,
         json={"foo": "baz"},
         status=200,
-        match_querystring=True,
+        match=[responses.matchers.query_param_matcher({})],
     )
 
     mgr = M(gl)
@@ -289,7 +289,7 @@ class M(DeleteMixin, FakeManager):
         url=url,
         json="",
         status=200,
-        match_querystring=True,
+        match=[responses.matchers.query_param_matcher({})],
     )
 
     mgr = M(gl)
@@ -311,7 +311,7 @@ class TestClass(SaveMixin, base.RESTObject):
         url=url,
         json={"id": 42, "foo": "baz"},
         status=200,
-        match_querystring=True,
+        match=[responses.matchers.query_param_matcher({})],
     )
 
     mgr = M(gl)
@@ -334,7 +334,7 @@ class M(SetMixin, FakeManager):
         url=url,
         json={"key": "foo", "value": "bar"},
         status=200,
-        match_querystring=True,
+        match=[responses.matchers.query_param_matcher({})],
     )
 
     mgr = M(gl)
diff --git a/tests/unit/test_gitlab.py b/tests/unit/test_gitlab.py
@@ -58,7 +58,7 @@ def resp_page_1():
         "headers": headers,
         "content_type": "application/json",
         "status": 200,
-        "match_querystring": True,
+        "match": [responses.matchers.query_param_matcher({})],
     }
 
 
@@ -81,7 +81,6 @@ def resp_page_2():
         "content_type": "application/json",
         "status": 200,
         "match": [responses.matchers.query_param_matcher(params)],
-        "match_querystring": False,
     }
 
 

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ def resp_page_1():`
`58`	`58`	`"headers": headers,`
`59`	`59`	`"content_type": "application/json",`
`60`	`60`	`"status": 200,`
`61`		`- "match_querystring": True,`
	`61`	`+ "match": [responses.matchers.query_param_matcher({})],`
`62`	`62`	`}`
`63`	`63`
`64`	`64`
`@@ -81,7 +81,6 @@ def resp_page_2():`
`81`	`81`	`"content_type": "application/json",`
`82`	`82`	`"status": 200,`
`83`	`83`	`"match": [responses.matchers.query_param_matcher(params)],`
`84`		`- "match_querystring": False,`
`85`	`84`	`}`
`86`	`85`
`87`	`86`