refactor(api): use JsonAttribute for feature flag strategies

amimas · amimas · commit c36cc8ab5dac · 2026-03-15T17:53:35.000-04:00
Add `JsonAttribute` to `gitlab.types` to handle JSON parsing for CLI
arguments.

Update `ProjectFeatureFlagManager` to use `JsonAttribute` for the
`strategies` attribute, replacing custom `create` and `update` overrides.
diff --git a/gitlab/types.py b/gitlab/types.py
@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import dataclasses
+import json
 from typing import Any, TYPE_CHECKING
 
 
@@ -49,6 +50,14 @@ def get_for_api(self, *, key: str) -> tuple[str, Any]:
         return (key, self._value)
 
 
+class JsonAttribute(GitlabAttribute):
+    def set_from_cli(self, cli_value: str) -> None:
+        if not cli_value.strip():
+            self._value = None
+        else:
+            self._value = json.loads(cli_value)
+
+
 class _ListArrayAttribute(GitlabAttribute):
     """Helper class to support `list` / `array` types."""
 
diff --git a/gitlab/v4/objects/feature_flags.py b/gitlab/v4/objects/feature_flags.py
@@ -5,9 +5,7 @@
 
 from __future__ import annotations
 
-import json
-from typing import Any
-
+from gitlab import types
 from gitlab.base import RESTObject
 from gitlab.mixins import CRUDMixin, ObjectDeleteMixin, SaveMixin
 from gitlab.types import RequiredOptional
@@ -28,53 +26,4 @@ class ProjectFeatureFlagManager(CRUDMixin[ProjectFeatureFlag]):
     )
     _update_attrs = RequiredOptional(optional=("description", "active", "strategies"))
     _list_filters = ("scope",)
-
-    def create(
-        self, data: dict[str, Any] | None = None, **kwargs: Any
-    ) -> ProjectFeatureFlag:
-        """Create a new object.
-
-        Args:
-            data: Parameters to send to the server to create the
-                         resource
-            **kwargs: Extra options to send to the server (e.g. sudo)
-
-        Returns:
-            A new instance of the managed object class build with
-                the data sent by the server
-        """
-        # Handle strategies being passed as a JSON string (e.g. from CLI)
-        if "strategies" in kwargs and isinstance(kwargs["strategies"], str):
-            kwargs["strategies"] = json.loads(kwargs["strategies"])
-        if data and "strategies" in data and isinstance(data["strategies"], str):
-            data["strategies"] = json.loads(data["strategies"])
-
-        return super().create(data, **kwargs)
-
-    def update(
-        self,
-        id: str | int | None = None,
-        new_data: dict[str, Any] | None = None,
-        **kwargs: Any,
-    ) -> dict[str, Any]:
-        """Update an object on the server.
-
-        Args:
-            id: ID of the object to update (can be None if not required)
-            new_data: the update data for the object
-            **kwargs: Extra options to send to the server (e.g. sudo)
-
-        Returns:
-            The new object data (*not* a RESTObject)
-        """
-        # Handle strategies being passed as a JSON string (e.g. from CLI)
-        if "strategies" in kwargs and isinstance(kwargs["strategies"], str):
-            kwargs["strategies"] = json.loads(kwargs["strategies"])
-        if (
-            new_data
-            and "strategies" in new_data
-            and isinstance(new_data["strategies"], str)
-        ):
-            new_data["strategies"] = json.loads(new_data["strategies"])
-
-        return super().update(id, new_data, **kwargs)
+    _types = {"strategies": types.JsonAttribute}
