fix(config): raise error when gitlab id provided but no config file found

nejch · JohnVillalovos · commit ac46c1cb291c · 2022-07-22T14:28:11.000-07:00
diff --git a/gitlab/config.py b/gitlab/config.py
@@ -128,6 +128,11 @@ def __init__(
         if self._files:
             self._parse_config()
 
+        if self.gitlab_id and not self._files:
+            raise GitlabConfigMissingError(
+                f"A gitlab id was provided ({self.gitlab_id}) but no config file found"
+            )
+
     def _parse_config(self) -> None:
         _config = configparser.ConfigParser()
         _config.read(self._files)
diff --git a/tests/unit/test_gitlab.py b/tests/unit/test_gitlab.py
@@ -25,6 +25,7 @@
 import responses
 
 import gitlab
+from gitlab.config import GitlabConfigMissingError
 from tests.unit import helpers
 
 localhost = "http://localhost"
@@ -299,6 +300,11 @@ def test_gitlab_from_config(default_config):
     gitlab.Gitlab.from_config("one", [config_path])
 
 
+def test_gitlab_from_config_without_files_raises():
+    with pytest.raises(GitlabConfigMissingError, match="non-existing"):
+        gitlab.Gitlab.from_config("non-existing")
+
+
 def test_gitlab_subclass_from_config(default_config):
     class MyGitlab(gitlab.Gitlab):
         pass
