Add ChunkedEncodingError to list of retryable exceptions

Clayton Walker · Clayton Walker · commit a746eedeb19f · 2022-04-11T12:59:08.000-06:00
diff --git a/gitlab/client.py b/gitlab/client.py
@@ -694,7 +694,7 @@ def http_request(
                     stream=streamed,
                     **opts,
                 )
-            except requests.ConnectionError:
+            except (requests.ConnectionError, requests.exceptions.ChunkedEncodingError):
                 if retry_transient_errors and (
                     max_retries == -1 or cur_retries < max_retries
                 ):
diff --git a/tests/unit/test_gitlab_http_methods.py b/tests/unit/test_gitlab_http_methods.py
@@ -129,6 +129,37 @@ def request_callback(request):
     assert len(responses.calls) == calls_before_success
 
 
+@responses.activate
+def test_http_request_with_retry_on_method_for_transient_network_failures_chunked(gl):
+    call_count = 0
+    calls_before_success = 3
+
+    url = "http://localhost/api/v4/projects"
+
+    def request_callback(request):
+        nonlocal call_count
+        call_count += 1
+        status_code = 200
+        headers = {}
+        body = "[]"
+
+        if call_count >= calls_before_success:
+            return (status_code, headers, body)
+        raise requests.exceptions.ChunkedEncodingError("Connection broken")
+
+    responses.add_callback(
+        method=responses.GET,
+        url=url,
+        callback=request_callback,
+        content_type="application/json",
+    )
+
+    http_r = gl.http_request("get", "/projects", retry_transient_errors=True)
+
+    assert http_r.status_code == 200
+    assert len(responses.calls) == calls_before_success
+
+
 @responses.activate
 def test_http_request_with_retry_on_class_for_transient_failures(gl_retry):
     call_count = 0

Original file line number	Diff line number	Diff line change
`@@ -694,7 +694,7 @@ def http_request(`
`694`	`694`	`stream=streamed,`
`695`	`695`	`**opts,`
`696`	`696`	`)`
`697`		`- except requests.ConnectionError:`
	`697`	`+ except (requests.ConnectionError, requests.exceptions.ChunkedEncodingError):`
`698`	`698`	`if retry_transient_errors and (`
`699`	`699`	`max_retries == -1 or cur_retries < max_retries`
`700`	`700`	`):`