test: don't use weak passwords

JohnVillalovos · JohnVillalovos · commit 9f4b695abe26 · 2023-02-13T08:05:21.000-08:00
Newer versions of GitLab will refuse to create a user with a weak
password. In order for us to move to a newer GitLab version in testing
use a stronger password for the tests that create a user.
diff --git a/tests/functional/api/test_groups.py b/tests/functional/api/test_groups.py
@@ -10,15 +10,15 @@ def test_groups(gl):
             "email": "user@test.com",
             "username": "user",
             "name": "user",
-            "password": "user_pass",
+            "password": "E4596f8be406Bc3a14a4ccdb1df80587#!1",
         }
     )
     user2 = gl.users.create(
         {
             "email": "user2@test.com",
             "username": "user2",
             "name": "user2",
-            "password": "user2_pass",
+            "password": "E4596f8be406Bc3a14a4ccdb1df80587#!#2",
         }
     )
     group1 = gl.groups.create(
diff --git a/tests/functional/api/test_users.py b/tests/functional/api/test_users.py
@@ -12,7 +12,7 @@ def test_create_user(gl, fixture_dir):
             "email": "foo@bar.com",
             "username": "foo",
             "name": "foo",
-            "password": "foo_password",
+            "password": "E4596f8be406Bc3a14a4ccdb1df80587#!",
             "avatar": open(fixture_dir / "avatar.png", "rb"),
         }
     )
@@ -65,7 +65,7 @@ def test_delete_user(gl, wait_for_sidekiq):
             "email": "delete-user@test.com",
             "username": "delete-user",
             "name": "delete-user",
-            "password": "delete-user-pass",
+            "password": "E4596f8be406Bc3a14a4ccdb1df80587#!",
         }
     )
 
@@ -100,7 +100,7 @@ def test_list_multiple_users(gl, user):
             "email": second_email,
             "username": second_username,
             "name": "Foo Bar",
-            "password": "foobar_password",
+            "password": "E4596f8be406Bc3a14a4ccdb1df80587#!",
         }
     )
     assert gl.users.list(search=second_user.username)[0].id == second_user.id
diff --git a/tests/functional/cli/test_cli_v4.py b/tests/functional/cli/test_cli_v4.py
@@ -103,7 +103,7 @@ def test_create_user(gitlab_cli, gl):
     email = "fake@email.com"
     username = "user1"
     name = "User One"
-    password = "fakepassword"
+    password = "E4596f8be406Bc3a14a4ccdb1df80587#!"
 
     cmd = [
         "user",
diff --git a/tests/functional/conftest.py b/tests/functional/conftest.py
@@ -523,7 +523,7 @@ def user(gl):
     email = f"user{_id}@email.com"
     username = f"user{_id}"
     name = f"User {_id}"
-    password = "fakepassword"
+    password = "E4596f8be406Bc3a14a4ccdb1df80587#!"
 
     user = gl.users.create(email=email, username=username, name=name, password=password)
 

Original file line number	Diff line number	Diff line change
`@@ -10,15 +10,15 @@ def test_groups(gl):`
`10`	`10`	`"email": "user@test.com",`
`11`	`11`	`"username": "user",`
`12`	`12`	`"name": "user",`
`13`		`- "password": "user_pass",`
	`13`	`+ "password": "E4596f8be406Bc3a14a4ccdb1df80587#!1",`
`14`	`14`	`}`
`15`	`15`	`)`
`16`	`16`	`user2 = gl.users.create(`
`17`	`17`	`{`
`18`	`18`	`"email": "user2@test.com",`
`19`	`19`	`"username": "user2",`
`20`	`20`	`"name": "user2",`
`21`		`- "password": "user2_pass",`
	`21`	`+ "password": "E4596f8be406Bc3a14a4ccdb1df80587#!#2",`
`22`	`22`	`}`
`23`	`23`	`)`
`24`	`24`	`group1 = gl.groups.create(`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ def test_create_user(gl, fixture_dir):`
`12`	`12`	`"email": "foo@bar.com",`
`13`	`13`	`"username": "foo",`
`14`	`14`	`"name": "foo",`
`15`		`- "password": "foo_password",`
	`15`	`+ "password": "E4596f8be406Bc3a14a4ccdb1df80587#!",`
`16`	`16`	`"avatar": open(fixture_dir / "avatar.png", "rb"),`
`17`	`17`	`}`
`18`	`18`	`)`
`@@ -65,7 +65,7 @@ def test_delete_user(gl, wait_for_sidekiq):`
`65`	`65`	`"email": "delete-user@test.com",`
`66`	`66`	`"username": "delete-user",`
`67`	`67`	`"name": "delete-user",`
`68`		`- "password": "delete-user-pass",`
	`68`	`+ "password": "E4596f8be406Bc3a14a4ccdb1df80587#!",`
`69`	`69`	`}`
`70`	`70`	`)`
`71`	`71`
`@@ -100,7 +100,7 @@ def test_list_multiple_users(gl, user):`
`100`	`100`	`"email": second_email,`
`101`	`101`	`"username": second_username,`
`102`	`102`	`"name": "Foo Bar",`
`103`		`- "password": "foobar_password",`
	`103`	`+ "password": "E4596f8be406Bc3a14a4ccdb1df80587#!",`
`104`	`104`	`}`
`105`	`105`	`)`
`106`	`106`	`assert gl.users.list(search=second_user.username)[0].id == second_user.id`