chore: fix issue with adding type-hints to 'manager' attribute

JohnVillalovos · JohnVillalovos · commit 9a451a892d37 · 2021-11-21T22:37:56.000-08:00
When attempting to add type-hints to the the 'manager' attribute into
a RESTObject derived class it would break things.

This was because our auto-manager creation code would automatically
add the specified annotated manager to the 'manager' attribute. This
breaks things.

Now check in our auto-manager creation if our attribute is called
'manager'. If so we ignore it.
diff --git a/gitlab/base.py b/gitlab/base.py
@@ -150,6 +150,10 @@ def _create_managers(self) -> None:
         # annotations. If an attribute is annotated as being a *Manager type
         # then we create the manager and assign it to the attribute.
         for attr, annotation in sorted(self.__annotations__.items()):
+            # We ignore creating a manager for the 'manager' attribute as that
+            # is done in the self.__init__() method
+            if attr in ("manager",):
+                continue
             if not isinstance(annotation, (type, str)):
                 continue
             if isinstance(annotation, type):
