fix(cli): allow exclusive arguments as optional

Sjord · Sjord · commit 9a16bdd84c76 · 2024-01-21T17:30:54.000+01:00
The CLI takes its arguments from the RequiredOptional, which has three fields: required, optional, and exclusive. In practice, the exclusive options are not defined as either required or optional, and would not be allowed in the CLI. This changes that, so that exclusive options are also added to the argument parser. Closes #2769
diff --git a/gitlab/v4/cli.py b/gitlab/v4/cli.py
@@ -258,7 +258,7 @@ def _populate_sub_parser_by_class(
                 sub_parser_action.add_argument(
                     f"--{x.replace('_', '-')}", required=True
                 )
-            for x in mgr_cls._create_attrs.optional:
+            for x in mgr_cls._create_attrs.optional + mgr_cls._create_attrs.exclusive:
                 sub_parser_action.add_argument(
                     f"--{x.replace('_', '-')}", required=False
                 )
@@ -274,7 +274,7 @@ def _populate_sub_parser_by_class(
                         f"--{x.replace('_', '-')}", required=True
                     )
 
-            for x in mgr_cls._update_attrs.optional:
+            for x in mgr_cls._update_attrs.optional + mgr_cls._update_attrs.exclusive:
                 if x != cls._id_attr:
                     sub_parser_action.add_argument(
                         f"--{x.replace('_', '-')}", required=False

Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,7 @@ def _populate_sub_parser_by_class(`
`258`	`258`	`sub_parser_action.add_argument(`
`259`	`259`	`f"--{x.replace('_', '-')}", required=True`
`260`	`260`	`)`
`261`		`- for x in mgr_cls._create_attrs.optional:`
	`261`	`+ for x in mgr_cls._create_attrs.optional + mgr_cls._create_attrs.exclusive:`
`262`	`262`	`sub_parser_action.add_argument(`
`263`	`263`	`f"--{x.replace('_', '-')}", required=False`
`264`	`264`	`)`
`@@ -274,7 +274,7 @@ def _populate_sub_parser_by_class(`
`274`	`274`	`f"--{x.replace('_', '-')}", required=True`
`275`	`275`	`)`
`276`	`276`
`277`		`- for x in mgr_cls._update_attrs.optional:`
	`277`	`+ for x in mgr_cls._update_attrs.optional + mgr_cls._update_attrs.exclusive:`
`278`	`278`	`if x != cls._id_attr:`
`279`	`279`	`sub_parser_action.add_argument(`
`280`	`280`	`f"--{x.replace('_', '-')}", required=False`