fix(client): handle empty 204 reponses in PUT requests

nejch · nejch · commit 9788524ee34c · 2023-11-22T16:21:36.000+01:00
diff --git a/gitlab/client.py b/gitlab/client.py
@@ -1061,6 +1061,8 @@ def http_put(
             raw=raw,
             **kwargs,
         )
+        if result.status_code in gitlab.const.NO_JSON_RESPONSE_CODES:
+            return result
         try:
             json_result = result.json()
             if TYPE_CHECKING:
diff --git a/tests/unit/test_gitlab_http_methods.py b/tests/unit/test_gitlab_http_methods.py
@@ -766,6 +766,21 @@ def test_put_request_404(gl):
     assert responses.assert_call_count(url, 1) is True
 
 
+@responses.activate
+def test_put_request_204(gl):
+    url = "http://localhost/api/v4/projects"
+    responses.add(
+        method=responses.PUT,
+        url=url,
+        status=204,
+        match=helpers.MATCH_EMPTY_QUERY_PARAMS,
+    )
+
+    result = gl.http_put("/projects")
+    assert isinstance(result, requests.Response)
+    assert responses.assert_call_count(url, 1) is True
+
+
 @responses.activate
 def test_put_request_invalid_data(gl):
     url = "http://localhost/api/v4/projects"

Original file line number	Diff line number	Diff line change
`@@ -1061,6 +1061,8 @@ def http_put(`
`1061`	`1061`	`raw=raw,`
`1062`	`1062`	`**kwargs,`
`1063`	`1063`	`)`
	`1064`	`+ if result.status_code in gitlab.const.NO_JSON_RESPONSE_CODES:`
	`1065`	`+ return result`
`1064`	`1066`	`try:`
`1065`	`1067`	`json_result = result.json()`
`1066`	`1068`	`if TYPE_CHECKING:`