fix: tests should not permanently remove parent groups

TimKnight-DWP · TimKnight-DWP · commit 92125b5d8a84 · 2024-02-08T14:08:36.000Z
Signed-off-by: Tim Knight &lt;tim.knight1@engineering.digital.dwp.gov.uk&gt;
diff --git a/tests/functional/helpers.py b/tests/functional/helpers.py
@@ -51,16 +51,15 @@ def safe_delete(object: gitlab.base.RESTObject) -> None:
                     # which combined with parents group never immediately deleting in GL 16
                     # we shouldn't cause test to fail if it still exists
                     return
-            elif (
-                type(object) is gitlab.v4.objects.Project
-                or type(object) is gitlab.v4.objects.Group
-            ):
+            elif type(object) is gitlab.v4.objects.Project:
                 # Immediately delete rather than waiting for at least 1day
                 # https://docs.gitlab.com/ee/api/projects.html#delete-project
-                # https://docs.gitlab.com/ee/api/projects.html#delete-group
                 object.delete(permanently_remove=True)
                 pass
             else:
+                # We only attempt to delete parent groups to prevent dangling sub-groups
+                # However parent groups can only be deleted on a delay in Gl 16
+                # https://docs.gitlab.com/ee/api/projects.html#delete-group
                 object.delete()
         except gitlab.exceptions.GitlabDeleteError:
             logging.info(f"{object!r} already deleted or scheduled for deletion.")
