fix: check attributes.require and .exclusive before using in _validate_attrs (utils.py)

walterrowe · walterrowe · commit 919440b4d8a6 · 2022-05-31T12:27:34.000-04:00
diff --git a/gitlab/utils.py b/gitlab/utils.py
@@ -171,18 +171,20 @@ def _validate_attrs(
     if excludes is None:
         excludes = []
 
-    required = [k for k in attributes.required if k not in excludes]
-    missing = [attr for attr in required if attr not in data]
-
-    if missing:
-        raise AttributeError(f"Missing attributes: {', '.join(missing)}")
-
-    exclusives = [attr for attr in data if attr in attributes.exclusive]
-    if len(exclusives) > 1:
-        raise AttributeError(
-            f"Provide only one of these attributes: {', '.join(exclusives)}"
-        )
-    if not exclusives:
-        raise AttributeError(
-            f"Must provide one of these attributes: {', '.join(attributes.exclusive)}"
-        )
+    if attributes.required:
+        required = [k for k in attributes.required if k not in excludes]
+        missing = [attr for attr in required if attr not in data]
+        if missing:
+            raise AttributeError(f"Missing attributes: {', '.join(missing)}")
+
+    if attributes.exclusive:
+        exclusives = [attr for attr in data if attr in attributes.exclusive]
+        if len(exclusives) > 1:
+            raise AttributeError(
+                f"Provide only one of these attributes: {', '.join(exclusives)}"
+            )
+        if not exclusives:
+            raise AttributeError(
+                "Must provide one of these attributes: %(attrs)s"
+                % {"attrs": ", ".join(attributes.exclusive)}
+            )
