chore: enable pylint check: "redefined-outer-name",

JohnVillalovos · JohnVillalovos · commit 7ca7a0095d37 · 2022-06-03T16:47:51.000-07:00
Enable the pylint check "redefined-outer-name" and fix the errors
detected.
diff --git a/gitlab/cli.py b/gitlab/cli.py
@@ -250,10 +250,10 @@ def _get_base_parser(add_help: bool = True) -> argparse.ArgumentParser:
 def _get_parser() -> argparse.ArgumentParser:
     # NOTE: We must delay import of gitlab.v4.cli until now or
     # otherwise it will cause circular import errors
-    import gitlab.v4.cli
+    from gitlab.v4 import cli as v4_cli
 
     parser = _get_base_parser()
-    return gitlab.v4.cli.extend_parser(parser)
+    return v4_cli.extend_parser(parser)
 
 
 def _parse_value(v: Any) -> Any:
diff --git a/gitlab/client.py b/gitlab/client.py
@@ -119,9 +119,8 @@ def __init__(
             raise ModuleNotFoundError(f"gitlab.v{self._api_version}.objects")
         # NOTE: We must delay import of gitlab.v4.objects until now or
         # otherwise it will cause circular import errors
-        import gitlab.v4.objects
+        from gitlab.v4 import objects
 
-        objects = gitlab.v4.objects
         self._objects = objects
         self.user: Optional[objects.CurrentUser] = None
 
@@ -214,9 +213,9 @@ def __setstate__(self, state: Dict[str, Any]) -> None:
             )  # pragma: no cover, dead code currently
         # NOTE: We must delay import of gitlab.v4.objects until now or
         # otherwise it will cause circular import errors
-        import gitlab.v4.objects
+        from gitlab.v4 import objects
 
-        self._objects = gitlab.v4.objects
+        self._objects = objects
 
     @property
     def url(self) -> str:
diff --git a/pyproject.toml b/pyproject.toml
@@ -59,7 +59,6 @@ disable = [
     "missing-module-docstring",
     "protected-access",
     "redefined-builtin",
-    "redefined-outer-name",
     "signature-differs",
     "too-few-public-methods",
     "too-many-ancestors",
