fix(client): properly parse content-type when charset is present

nejch · JohnVillalovos · commit 76063c386ef9 · 2023-03-12T10:09:58.000-07:00
diff --git a/gitlab/client.py b/gitlab/client.py
@@ -828,12 +828,9 @@ def http_get(
         result = self.http_request(
             "get", path, query_data=query_data, streamed=streamed, **kwargs
         )
+        content_type = utils.get_content_type(result.headers.get("Content-Type"))
 
-        if (
-            result.headers["Content-Type"] == "application/json"
-            and not streamed
-            and not raw
-        ):
+        if content_type == "application/json" and not streamed and not raw:
             try:
                 json_result = result.json()
                 if TYPE_CHECKING:
@@ -1030,8 +1027,10 @@ def http_post(
             raw=raw,
             **kwargs,
         )
+        content_type = utils.get_content_type(result.headers.get("Content-Type"))
+
         try:
-            if result.headers.get("Content-Type", None) == "application/json":
+            if content_type == "application/json":
                 json_result = result.json()
                 if TYPE_CHECKING:
                     assert isinstance(json_result, dict)
diff --git a/gitlab/utils.py b/gitlab/utils.py
@@ -1,3 +1,4 @@
+import email.message
 import pathlib
 import traceback
 import urllib.parse
@@ -14,6 +15,13 @@ def __call__(self, chunk: Any) -> None:
         print(chunk)
 
 
+def get_content_type(content_type: Optional[str]) -> str:
+    message = email.message.Message()
+    message["content-type"] = content_type
+
+    return message.get_content_type()
+
+
 def response_content(
     response: requests.Response,
     streamed: bool,
diff --git a/tests/unit/test_utils.py b/tests/unit/test_utils.py
@@ -8,6 +8,20 @@
 from gitlab import types, utils
 
 
+@pytest.mark.parametrize(
+    "content_type,expected_type",
+    [
+        ("application/json", "application/json"),
+        ("application/json; charset=utf-8", "application/json"),
+        ("", "text/plain"),
+        (None, "text/plain"),
+    ],
+)
+def test_get_content_type(content_type, expected_type):
+    parsed_type = utils.get_content_type(content_type)
+    assert parsed_type == expected_type
+
+
 @responses.activate
 def test_response_content(capsys):
     responses.add(
