fix: add ChunkedEncodingError to list of retryable exceptions

Clayton Walker · Clayton Walker · commit 7183898187a2 · 2022-04-13T10:14:24.000-06:00
diff --git a/gitlab/client.py b/gitlab/client.py
@@ -694,7 +694,7 @@ def http_request(
                     stream=streamed,
                     **opts,
                 )
-            except requests.ConnectionError:
+            except (requests.ConnectionError, requests.exceptions.ChunkedEncodingError):
                 if retry_transient_errors and (
                     max_retries == -1 or cur_retries < max_retries
                 ):
diff --git a/tests/unit/test_gitlab_http_methods.py b/tests/unit/test_gitlab_http_methods.py
@@ -99,7 +99,13 @@ def request_callback(request):
 
 
 @responses.activate
-def test_http_request_with_retry_on_method_for_transient_network_failures(gl):
+@pytest.mark.parametrize(
+    "exception", [
+        requests.ConnectionError("Connection aborted."),
+        requests.exceptions.ChunkedEncodingError("Connection broken.")
+    ]
+)
+def test_http_request_with_retry_on_method_for_transient_network_failures(gl, exception):
     call_count = 0
     calls_before_success = 3
 
@@ -114,7 +120,7 @@ def request_callback(request):
 
         if call_count >= calls_before_success:
             return (status_code, headers, body)
-        raise requests.ConnectionError("Connection aborted.")
+        raise exception
 
     responses.add_callback(
         method=responses.GET,

Original file line number	Diff line number	Diff line change
`@@ -694,7 +694,7 @@ def http_request(`
`694`	`694`	`stream=streamed,`
`695`	`695`	`**opts,`
`696`	`696`	`)`
`697`		`- except requests.ConnectionError:`
	`697`	`+ except (requests.ConnectionError, requests.exceptions.ChunkedEncodingError):`
`698`	`698`	`if retry_transient_errors and (`
`699`	`699`	`max_retries == -1 or cur_retries < max_retries`
`700`	`700`	`):`