fix(groups): adding unit test for list_ldap_group_sync - try 2

rpowellatanl · rpowellatanl · commit 6194085f9e43 · 2022-11-16T16:31:24.000Z
diff --git a/tests/unit/objects/test_groups.py b/tests/unit/objects/test_groups.py
@@ -224,6 +224,19 @@ def resp_delete_push_rules_group(no_content):
         yield rsps
 
 
+@pytest.fixture
+def resp_list_ldap_group_links(no_content):
+    with responses.RequestsMock() as rsps:
+        rsps.add(
+            method=responses.GET,
+            url="http://localhost/api/v4/groups/1/ldap_group_links",
+            json=ldap_group_links_content,
+            content_type="application/json",
+            status=200,
+        )
+        yield rsps
+
+
 def test_get_group(gl, resp_groups):
     data = gl.groups.get(1)
     assert isinstance(data, gitlab.v4.objects.Group)
@@ -269,17 +282,10 @@ def test_list_group_descendant_groups(group, resp_list_subgroups_descendant_grou
     assert descendant_groups[0].path == subgroup_descgroup_content[0]["path"]
 
 
-@pytest.fixture
-def resp_list_ldap_group_links(no_content):
-    with responses.RequestsMock() as rsps:
-        rsps.add(
-            method=responses.GET,
-            url="http://localhost/api/v4/groups/1/ldap_group_links",
-            json=ldap_group_links_content,
-            content_type="application/json",
-            status=200,
-        )
-        yield rsps
+def test_list_ldap_group_links(group, resp_list_ldap_group_links):
+    ldap_group_links = group.list_ldap_group_links()
+    assert isinstance(ldap_group_links, list)
+    assert ldap_group_links[0]["provider"] == ldap_group_links_content[0]["provider"]
 
 
 @pytest.mark.skip("GitLab API endpoint not implemented")
