Raise NotImplementedError on all cases, where can*-boolean is False

mjmaenpaa · mjmaenpaa · commit 555cc45638f1 · 2014-11-01T14:59:00.000+02:00
diff --git a/gitlab.py b/gitlab.py
@@ -552,20 +552,8 @@ def list(cls, gl, **kwargs):
     @classmethod
     def _getListOrObject(cls, gl, id, **kwargs):
         if id is None and cls.getListWhenNoId:
-            if not cls.canList:
-                raise GitlabListError
             return cls.list(gl, **kwargs)
-        elif id is None and not cls.getListWhenNoId:
-            if not cls.canGet:
-                raise GitlabGetError
-            return cls(gl, id, **kwargs)
-        elif isinstance(id, dict):
-            if not cls.canCreate:
-                raise GitlabCreateError
-            return cls(gl, id, **kwargs)
         else:
-            if not cls.canGet:
-                raise GitlabGetError
             return cls(gl, id, **kwargs)
 
     def _getObject(self, k, v):
@@ -621,6 +609,8 @@ def __init__(self, gl, data=None, **kwargs):
 
         if data is None or isinstance(data, six.integer_types) or\
                 isinstance(data, six.string_types):
+            if not self.canGet:
+                raise NotImplementedError
             data = self.gitlab.get(self.__class__, data, **kwargs)
             # Object is created because we got it from api
             self._created = True
