chore: add type-hints to setup.py and check with mypy

JohnVillalovos · JohnVillalovos · commit 4ab835fdadf2 · 2021-11-08T21:06:44.000-08:00
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -27,3 +27,4 @@ repos:
         additional_dependencies:
           - types-PyYAML==6.0.0
           - types-requests==2.25.12
+          - types-setuptools=57.4.2
diff --git a/pyproject.toml b/pyproject.toml
@@ -25,7 +25,6 @@ module = [
     "gitlab.v4.objects.services",
     "gitlab.v4.objects.sidekiq",
     "gitlab.v4.objects.snippets",
-    "setup",
     "tests.functional.*",
     "tests.functional.api.*",
     "tests.unit.*",
diff --git a/requirements-lint.txt b/requirements-lint.txt
@@ -4,3 +4,4 @@ isort==5.10.0
 mypy==0.910
 types-PyYAML==6.0.0
 types-requests==2.25.12
+types-setuptools=57.4.2
diff --git a/setup.py b/setup.py
@@ -4,11 +4,14 @@
 from setuptools import find_packages, setup
 
 
-def get_version():
+def get_version() -> str:
+    version = ""
     with open("gitlab/__version__.py") as f:
         for line in f:
             if line.startswith("__version__"):
-                return eval(line.split("=")[-1])
+                version = eval(line.split("=")[-1])
+                break
+    return version
 
 
 with open("README.rst", "r") as readme_file:
