Merge pull request #1862 from thomasgl-orange/cli-fix-timeout

max-wittig · web-flow · commit 3fb4486045dc · 2022-01-27T08:58:20.000+01:00
fix(cli): make 'timeout', 'per_page' and 'page' type explicit
diff --git a/gitlab/cli.py b/gitlab/cli.py
@@ -181,6 +181,7 @@ def _get_base_parser(add_help: bool = True) -> argparse.ArgumentParser:
             "[env var: GITLAB_TIMEOUT]"
         ),
         required=False,
+        type=int,
         default=os.getenv("GITLAB_TIMEOUT"),
     )
     parser.add_argument(
@@ -196,6 +197,7 @@ def _get_base_parser(add_help: bool = True) -> argparse.ArgumentParser:
             "[env var: GITLAB_PER_PAGE]"
         ),
         required=False,
+        type=int,
         default=os.getenv("GITLAB_PER_PAGE"),
     )
     parser.add_argument(
diff --git a/gitlab/v4/cli.py b/gitlab/v4/cli.py
@@ -218,8 +218,8 @@ def _populate_sub_parser_by_class(
                     f"--{x.replace('_', '-')}", required=False
                 )
 
-            sub_parser_action.add_argument("--page", required=False)
-            sub_parser_action.add_argument("--per-page", required=False)
+            sub_parser_action.add_argument("--page", required=False, type=int)
+            sub_parser_action.add_argument("--per-page", required=False, type=int)
             sub_parser_action.add_argument("--all", required=False, action="store_true")
 
         if action_name == "delete":

Original file line number	Diff line number	Diff line change
`@@ -218,8 +218,8 @@ def _populate_sub_parser_by_class(`
`218`	`218`	`f"--{x.replace('_', '-')}", required=False`
`219`	`219`	`)`
`220`	`220`
`221`		`- sub_parser_action.add_argument("--page", required=False)`
`222`		`- sub_parser_action.add_argument("--per-page", required=False)`
	`221`	`+ sub_parser_action.add_argument("--page", required=False, type=int)`
	`222`	`+ sub_parser_action.add_argument("--per-page", required=False, type=int)`
`223`	`223`	`sub_parser_action.add_argument("--all", required=False, action="store_true")`
`224`	`224`
`225`	`225`	`if action_name == "delete":`