fix(config): raise error when gitlab id provided but no config section found

nejch · JohnVillalovos · commit 1ef70188da1e · 2022-07-22T14:28:11.000-07:00
diff --git a/gitlab/config.py b/gitlab/config.py
@@ -137,6 +137,12 @@ def _parse_config(self) -> None:
         _config = configparser.ConfigParser()
         _config.read(self._files)
 
+        if self.gitlab_id and not _config.has_section(self.gitlab_id):
+            raise GitlabDataError(
+                f"A gitlab id was provided ({self.gitlab_id}) "
+                "but no config section found"
+            )
+
         if self.gitlab_id is None:
             try:
                 self.gitlab_id = _config.get("global", "default")
diff --git a/tests/unit/test_gitlab.py b/tests/unit/test_gitlab.py
@@ -25,7 +25,7 @@
 import responses
 
 import gitlab
-from gitlab.config import GitlabConfigMissingError
+from gitlab.config import GitlabConfigMissingError, GitlabDataError
 from tests.unit import helpers
 
 localhost = "http://localhost"
@@ -305,6 +305,11 @@ def test_gitlab_from_config_without_files_raises():
         gitlab.Gitlab.from_config("non-existing")
 
 
+def test_gitlab_from_config_with_wrong_gitlab_id_raises(default_config):
+    with pytest.raises(GitlabDataError, match="non-existing"):
+        gitlab.Gitlab.from_config("non-existing", [default_config])
+
+
 def test_gitlab_subclass_from_config(default_config):
     class MyGitlab(gitlab.Gitlab):
         pass
