test: add tests for token masking

nejch · JohnVillalovos · commit 163bfcf6c2c1 · 2023-10-13T08:27:23.000-07:00
diff --git a/tests/functional/cli/test_cli.py b/tests/functional/cli/test_cli.py
@@ -198,3 +198,12 @@ def test_cli_display_without_fields_warns(gitlab_cli, project):
 
     assert "No default fields to show" in ret.stdout
     assert "merged_yaml" not in ret.stdout
+
+
+def test_cli_does_not_print_token(gitlab_cli, gitlab_token):
+    ret = gitlab_cli(["--debug", "current-user", "get"])
+    assert ret.success
+
+    assert gitlab_token not in ret.stdout
+    assert gitlab_token not in ret.stderr
+    assert "[MASKED]" in ret.stderr
diff --git a/tests/unit/test_utils.py b/tests/unit/test_utils.py
@@ -1,4 +1,5 @@
 import json
+import logging
 import warnings
 
 import pytest
@@ -197,3 +198,19 @@ def test_transform_types_not_params_array():
     assert new_data is not data
     assert new_data == data
     assert files == {}
+
+
+def test_masking_formatter_masks_token(capsys: pytest.CaptureFixture):
+    token = "glpat-private-token"
+
+    logger = logging.getLogger()
+    handler = logging.StreamHandler()
+    handler.setFormatter(utils.MaskingFormatter(masked=token))
+    logger.handlers.clear()
+    logger.addHandler(handler)
+
+    logger.info(token)
+    captured = capsys.readouterr()
+
+    assert "[MASKED]" in captured.err
+    assert token not in captured.err
