chore: add basic typing to test root

nejch · JohnVillalovos · commit 0b2f6bcf4546 · 2022-10-27T08:06:52.000-07:00
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -35,6 +35,7 @@ repos:
       - id: mypy
         args: []
         additional_dependencies:
+          - pytest==7.1.3
           - types-PyYAML==6.0.12
           - types-requests==2.28.11.2
           - types-setuptools==64.0.1
diff --git a/pyproject.toml b/pyproject.toml
@@ -29,9 +29,9 @@ warn_unused_ignores = true
 module = [
     "docs.*",
     "docs.ext.*",
-    "tests.*",
     "tests.functional.*",
     "tests.functional.api.*",
+    "tests.meta.*",
     "tests.unit.*",
     "tests.smoke.*"
 ]
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -1,15 +1,18 @@
+import pathlib
+
+import _pytest.config
 import pytest
 
 import gitlab
 
 
 @pytest.fixture(scope="session")
-def test_dir(pytestconfig):
-    return pytestconfig.rootdir / "tests"
+def test_dir(pytestconfig: _pytest.config.Config) -> pathlib.Path:
+    return pytestconfig.rootdir / "tests"  # type: ignore
 
 
 @pytest.fixture(autouse=True)
-def mock_clean_config(monkeypatch):
+def mock_clean_config(monkeypatch: pytest.MonkeyPatch) -> None:
     """Ensures user-defined environment variables do not interfere with tests."""
     monkeypatch.delenv("PYTHON_GITLAB_CFG", raising=False)
     monkeypatch.delenv("GITLAB_PRIVATE_TOKEN", raising=False)
@@ -19,19 +22,19 @@ def mock_clean_config(monkeypatch):
 
 
 @pytest.fixture(autouse=True)
-def default_files(monkeypatch):
+def default_files(monkeypatch: pytest.MonkeyPatch) -> None:
     """Ensures user configuration files do not interfere with tests."""
     monkeypatch.setattr(gitlab.config, "_DEFAULT_FILES", [])
 
 
 @pytest.fixture
-def valid_gitlab_ci_yml():
+def valid_gitlab_ci_yml() -> str:
     return """---
 :test_job:
   :script: echo 1
 """
 
 
 @pytest.fixture
-def invalid_gitlab_ci_yml():
+def invalid_gitlab_ci_yml() -> str:
     return "invalid"
