Merge pull request #1008 from filipowm/feature/feature-flags-additional-config

max-wittig · web-flow · commit 066fc9bfdc1d · 2020-02-10T08:15:50.000+01:00
Add capability to control GitLab features per project or group
diff --git a/docs/gl_objects/features.rst b/docs/gl_objects/features.rst
@@ -24,6 +24,8 @@ Create or set a feature::
 
     feature = gl.features.set(feature_name, True)
     feature = gl.features.set(feature_name, 30)
+    feature = gl.features.set(feature_name, True, user=filipowm)
+    feature = gl.features.set(feature_name, 40, group=mygroup)
 
 Delete a feature::
 
diff --git a/gitlab/utils.py b/gitlab/utils.py
@@ -55,3 +55,7 @@ def sanitized_url(url):
     parsed = urlparse(url)
     new_path = parsed.path.replace(".", "%2E")
     return parsed._replace(path=new_path).geturl()
+
+
+def remove_none_from_dict(data):
+    return {k: v for k, v in data.items() if v is not None}
diff --git a/gitlab/v4/objects.py b/gitlab/v4/objects.py
@@ -724,14 +724,25 @@ class FeatureManager(ListMixin, DeleteMixin, RESTManager):
     _obj_cls = Feature
 
     @exc.on_http_error(exc.GitlabSetError)
-    def set(self, name, value, feature_group=None, user=None, **kwargs):
+    def set(
+        self,
+        name,
+        value,
+        feature_group=None,
+        user=None,
+        group=None,
+        project=None,
+        **kwargs
+    ):
         """Create or update the object.
 
         Args:
             name (str): The value to set for the object
             value (bool/int): The value to set for the object
             feature_group (str): A feature group name
             user (str): A GitLab username
+            group (str): A GitLab group
+            project (str): A GitLab project in form group/project
             **kwargs: Extra options to send to the server (e.g. sudo)
 
         Raises:
@@ -742,7 +753,14 @@ def set(self, name, value, feature_group=None, user=None, **kwargs):
             obj: The created/updated attribute
         """
         path = "%s/%s" % (self.path, name.replace("/", "%2F"))
-        data = {"value": value, "feature_group": feature_group, "user": user}
+        data = {
+            "value": value,
+            "feature_group": feature_group,
+            "user": user,
+            "group": group,
+            "project": project,
+        }
+        data = utils.remove_none_from_dict(data)
         server_data = self.gitlab.http_post(path, post_data=data, **kwargs)
         return self._obj_cls(self, server_data)
 
