Skip to content

Commit 046fbac

Browse files
maretodoricJohnVillalovos
maretodoric
authored and
JohnVillalovos
committed
fix(client): retry fetching server version after an unknown result
Previously, once `version()` failed to retrieve the server version and cached "unknown" for `_server_version`/`_server_revision`, all subsequent calls would short-circuit on the `is None` check and keep returning the cached "unknown" values forever, even if the server was reachable again. Now `version()` also retries when the cached value is "unknown".
1 parent 72134f5 commit 046fbac

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎gitlab/client.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ def version(self) -> tuple[str, str]:
404404
The server version and server revision.
405405
('unknown', 'unknown') if the server doesn't perform as expected.
406406
"""
407-
if self._server_version is None:
407+
if self._server_version in (None, "unknown"):
408408
try:
409409
data = self.http_get("/version")
410410
if isinstance(data, dict):

0 commit comments

Comments
 (0)