Skip to content

ellar package dependency refactor - #89

Merged
eadwinCode merged 5 commits into
mainfrom
package_dependency_fix
May 11, 2023
Merged

ellar package dependency refactor#89
eadwinCode merged 5 commits into
mainfrom
package_dependency_fix

Conversation

@eadwinCode

Copy link
Copy Markdown
Collaborator

Whats Changes

  • Properly depend package dependencies
  • ellar.common will hold common implementation for ellar.core and other packages dependent on ellar.core
  • ellar.core will hold core implementation of interfaces exposed in ellar.common
  • ellar.di will stand on its own free of ellar.common and ellar.core
  • ellar.reflect will stand on its own
  • ellar.cache, ellar.openapi, ellar.testing, ellar.socketio will all depend on ellar.common and ellar.core

@codecov-commenter

codecov-commenter commented May 6, 2023

Copy link
Copy Markdown

Codecov Report

Merging #89 (50365f8) into main (f187293) will increase coverage by 0.23%.
The diff coverage is 99.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   97.07%   97.31%   +0.23%     
==========================================
  Files         205      221      +16     
  Lines        6539     6588      +49     
==========================================
+ Hits         6348     6411      +63     
+ Misses        191      177      -14     
Impacted Files Coverage Δ
ellar/common/commands/base.py 77.77% <ø> (ø)
ellar/common/compatible/__init__.py 100.00% <ø> (ø)
ellar/common/converters.py 100.00% <ø> (ø)
ellar/common/datastructures.py 100.00% <ø> (ø)
ellar/common/decorators/__init__.py 100.00% <ø> (ø)
ellar/common/exceptions/api/base.py 91.30% <ø> (ø)
ellar/common/exceptions/api/exceptions_types.py 100.00% <ø> (ø)
ellar/common/exceptions/context.py 100.00% <ø> (ø)
ellar/common/exceptions/validation.py 100.00% <ø> (ø)
ellar/common/helper/__init__.py 100.00% <ø> (ø)
... and 171 more

@eadwinCode
eadwinCode merged commit 4cbef48 into main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants