Skip to content

Feat(LazyModuleImport): New feature - #155

Merged
eadwinCode merged 1 commit into
mainfrom
lazy_module_import
Dec 7, 2023
Merged

Feat(LazyModuleImport): New feature#155
eadwinCode merged 1 commit into
mainfrom
lazy_module_import

Conversation

@eadwinCode

@eadwinCode eadwinCode commented Dec 7, 2023

Copy link
Copy Markdown
Collaborator

Whats new

  • Added support to lazily load a ellar module through string import
# In module.py
import ellar.common as ecm

@ecm.Module()
class ModuleSample:
    pass

# in ApplicationModule
import ellar.core as eco
import ellar.common as ecm


@ecm.Module(modules=[eco.LazyModuleImport('project.module:ModuleSample')])
class ApplicationModule(eco.ModuleBase):
   pass

@codecov

codecov Bot commented Dec 7, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7be09f) 99.53% compared to head (c7aab28) 99.53%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files         290      289    -1     
  Lines        7972     7996   +24     
=======================================
+ Hits         7935     7959   +24     
  Misses         37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eadwinCode
eadwinCode merged commit f3e3902 into main Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eadwinCode