[BACKWARDS INCOMPATIBLE] Use exception instances instead of exc_info tuples #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that effect now only supports Python 3 and above.
… with old users of effect that were using python 2
Contributor
Author
|
After merging this, I will release Effect 1.0. |
Contributor
|
<3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24 (Passing around exc_info tuples sucks)
Ripping off the bandaid:
Everywhere where we used to deal with exc_info tuples, we now use Exception instances. This works in Python3 because Exception instances carry around their tracebacks.