Skip to content

fix damp command natural frequency printout for discrete poles on real axis #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
murrayrm merged 3 commits into from
May 28, 2023
Merged

fix damp command natural frequency printout for discrete poles on real axis #894

murrayrm merged 3 commits into from
May 28, 2023

Conversation

@sawyerbfuller
Copy link
Contributor

@sawyerbfuller sawyerbfuller commented May 22, 2023

The damp command was assuming a cont-time system when printing out pole locations (but the return value was correct). Fixed, along with making a few docstring improvements.

@sawyerbfuller
Copy link
Contributor Author

sawyerbfuller commented May 23, 2023

Example:

sysd = ct.zpk([], [-1.1, 1+1j, 1-1j], 1, True)
ct.damp(sysd)

Old (pole at -1.1 has the wrong frequency, table is hard to read):

_____Eigenvalue______ Damping___ Frequency_
         1        +1j    -0.4037     0.8585
         1        -1j    -0.4037     0.8585
      -1.1                     1        1.1

New:

    Eigenvalue (pole)       Damping     Frequency
         1        +1j       -0.4037        0.8585
         1        -1j       -0.4037        0.8585
                 -1.1             1         3.143

@murrayrm
Copy link
Member

murrayrm commented May 28, 2023

LGTM.

@murrayrm murrayrm merged commit 1b84d80 into python-control:main May 28, 2023
@murrayrm murrayrm added this to the 0.9.4 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.4

Development

Successfully merging this pull request may close these issues.

2 participants

@sawyerbfuller @murrayrm