Small fixes based on Caltech CDS 112 course #849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 14, 2023
bnavigator
reviewed
Jan 15, 2023
| type : 'linear' or 'nonlinear', optional | ||
| controller_type : 'linear' or 'nonlinear', optional |
Contributor
There was a problem hiding this comment.
That's an API change. The milestone should be 0.10.0 (or 1.0.0) then.
Member
Author
There was a problem hiding this comment.
I put in code to handle legacy calls, so type will still work. See line 732.
murrayrm
force-pushed
the
cds112_fixes-12Jan2023
branch
from
10bcd65 to
ed03726
Compare
bnavigator
force-pushed
the
cds112_fixes-12Jan2023
branch
from
ed03726 to
91c0260
Compare
Contributor
|
Rebased onto current main, in order to resolve conflicts due to #857 |
murrayrm
force-pushed
the
cds112_fixes-12Jan2023
branch
from
67ea154 to
8e40c90
Compare
murrayrm
force-pushed
the
cds112_fixes-12Jan2023
branch
from
49756c4 to
574cf69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some small fixes that I discovered while teaching CDS 112 at Caltech in Winter 2023:
create_statefbk_iosystemthat didn't proper handle 1D gain schedules.flatsys.point_to_pointgenerates an error if you specify a cost or constraint with less than 3 time points.LinearIOSystemreturns aLinearIOSystem(before it returned aStateSpacesystem).add_unusedkeyword parameter tointerconnectthat allows unused inputs or outputs to be added as inputs or outputs of the interconnected system (useful for doing a "partial" interconnection).create_mpc_iosystemnow allows system and signal names to be specified via appropriate keywords.typekeyword forcreate_statefbk_iosystemtocontroller_type(linear or nonlinear). Usingtypegenerates a deprecation warning.control_indicesandstate_indicestocreate_statefbk_iosystemto allow partial interconnection (eg, for inner/outer loop construction).