Skip to content

Move sys._update_params(params) before TimeResponseData return when nstate == 0 #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bnavigator merged 2 commits into from
Oct 9, 2022
Merged

Move sys._update_params(params) before TimeResponseData return when nstate == 0 #774

bnavigator merged 2 commits into from
Oct 9, 2022

Conversation

@hyumo
Copy link

@hyumo hyumo commented Oct 3, 2022 •
edited
Loading

It was found that for system without states, params not are updated at the right timing in the input_output_response function.

Need to move sys._update_params(params) before TimeResponseData returns if nstate == 0

@coveralls
Copy link

coveralls commented Oct 8, 2022

Coverage Status

Coverage remained the same at 94.766% when pulling 8aa271d on hyumo:main into f758725 on python-control:main.

@bnavigator
Copy link
Contributor

bnavigator commented Oct 9, 2022

Thank you

@bnavigator bnavigator merged commit 61ef12b into python-control:main Oct 9, 2022
@murrayrm murrayrm added this to the 0.9.3 milestone Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.3

Development

Successfully merging this pull request may close these issues.

4 participants

@hyumo @coveralls @bnavigator @murrayrm