Skip to content

fix #523: finding z for |H(z)|=1 computed the wrong polynomials #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bnavigator merged 2 commits into from
Jan 30, 2021
Merged

fix #523: finding z for |H(z)|=1 computed the wrong polynomials #525

bnavigator merged 2 commits into from
Jan 30, 2021

Conversation

@bnavigator
Copy link
Contributor

@bnavigator bnavigator commented Jan 30, 2021

Even the reference values for the tests were wrong.

@bnavigator bnavigator linked an issue Jan 30, 2021 that may be closed by this pull request
stability_margins doesn't find gain=1 crossover frequency correctly for DT systems #523
Closed
@coveralls
Copy link

coveralls commented Jan 30, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 87.754% when pulling 48a18d6 on bnavigator:fix-523 into 6d51358 on python-control:master.

@bnavigator bnavigator merged commit 649215e into python-control:master Jan 30, 2021
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
@bnavigator bnavigator deleted the fix-523 branch February 18, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawyerbfuller sawyerbfuller sawyerbfuller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

stability_margins doesn't find gain=1 crossover frequency correctly for DT systems

4 participants

@bnavigator @coveralls @sawyerbfuller @murrayrm