Skip to content

fix latex representation for exp format and multi-digit exponents of s or z#330

Merged
murrayrm merged 6 commits into
python-control:masterfrom
bnavigator:fix-latex
Dec 31, 2019
Merged

fix latex representation for exp format and multi-digit exponents of s or z#330
murrayrm merged 6 commits into
python-control:masterfrom
bnavigator:fix-latex

Conversation

@bnavigator

Copy link
Copy Markdown
Contributor

quickfix for #278

@coveralls

coveralls commented Jul 22, 2019

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.03%) to 84.653% when pulling af08a30 on bnavigator:fix-latex into 4785145 on python-control:master.

@murrayrm

Copy link
Copy Markdown
Member

I think normal scientific notation uses \times instead of \cdot. Is there a reason not to use \times?

Also, scientific notation in Python uses a leading 0 and so 100 becomes 1e02 which becomes 10^{02}, which looks a bit odd. Can you strip the leading 0?

Also, not a huge deal, but might be nice to have some unit tests to verify this works correctly.

@bnavigator

Copy link
Copy Markdown
Contributor Author

Both seems to exist. See for example the documentation for the LaTeX siunitx package, page 28. I am used to \cdot, but maybe that's just more common here in Germany. How about having it configurable in the .config module and set \times as default?

@bnavigator

Copy link
Copy Markdown
Contributor Author

Coveralls is a mystery to me.

@murrayrm murrayrm added this to the 0.8.3 milestone Dec 31, 2019
@murrayrm murrayrm merged commit fe6d774 into python-control:master Dec 31, 2019
@bnavigator bnavigator deleted the fix-latex branch July 26, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants