Skip to content

Improve detection of when to add additional points to root_locus #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
murrayrm merged 1 commit into from
Jun 17, 2019
Merged

Improve detection of when to add additional points to root_locus #313

murrayrm merged 1 commit into from
Jun 17, 2019

Conversation

@murrayrm
Copy link
Member

@murrayrm murrayrm commented Jun 9, 2019

This PR provides improved checking of when to add points to a root locus plot and hence decreases the number of extraneous points that are generated. See issue #310 for details. The change is to detect when the root locus is on a line (typically the real axis) and to correct a calculation that was causing all points to be expanded (unnecessarily).

Also did some PEP8 and numpydoc cleanup while I was in the file.

@coveralls
Copy link

coveralls commented Jun 9, 2019

Coverage Status

Coverage decreased (-0.01%) to 82.098% when pulling 3c68cf1 on murrayrm:rlocus_speedup into e2346cd on python-control:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 9, 2019

Coverage Status

Coverage decreased (-0.01%) to 82.098% when pulling 3c68cf1 on murrayrm:rlocus_speedup into e2346cd on python-control:master.

@murrayrm murrayrm changed the title Improve detection of when to add additional points to root_loucs Improve detection of when to add additional points to root_locus Jun 9, 2019
@murrayrm
Copy link
Member Author

murrayrm commented Jun 9, 2019

@icam0, @gonmolina, @repagh Small fix to root_locus. Since you have all worked on this file, would be great if you could take a quick look to make sure that what I am doing makes sense.

@murrayrm murrayrm merged commit 089936f into python-control:master Jun 17, 2019
@murrayrm murrayrm deleted the rlocus_speedup branch June 17, 2019 00:44
@repagh
Copy link
Member

repagh commented Jun 17, 2019

There were many formatting changes, so I couldn't easily find the functional change.
I threw the problems at it which were getting odd-angled root-loci with the old code (before this spring's fixes), and these were handled fine.

Will add these as an example later.

@murrayrm murrayrm added this to the 0.8.3 milestone Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.8.3

Development

Successfully merging this pull request may close these issues.

3 participants

@murrayrm @coveralls @repagh