Skip to content

Refactor place method #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
don4get wants to merge 7 commits into from
Closed

Refactor place method #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f346b75
[statefbk.py] Refactor style
don4get Jan 5, 2019
1fbc803
[exception.py] Clean except case
don4get Jan 5, 2019
e98374e
[statefbk.py] Refactor place, induce change in API
don4get Jan 5, 2019
7b0f7d7
[statefbk_test.py] Fix pep8 warnings
don4get Jan 5, 2019
02d5cd5
[test_statefbk.py] Clean style and remove matrix usage
don4get Jan 5, 2019
ae10ed9
Test place with varga method only if slycot is installed
don4get Jan 5, 2019
12fc6be
Implement comments from pull request
don4get Apr 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions control/exception.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,32 +39,44 @@
#
# $Id$


class ControlSlycot(Exception):
"""Exception for Slycot import. Used when we can't import a function
from the slycot package"""
pass
def __init__(self, error):

@repagh repagh Apr 16, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is the right approach to immediately print this error reason. This creates an exception with a by-product.

This also does not call Exception.init, (which would normally store the error string) so if caught and printed later, the original exception reason has disappeared.

print("slycot import failed")
print(error)


class ControlDimension(Exception):
"""Raised when dimensions of system objects are not correct"""
pass


class ControlArgument(Exception):
"""Raised when arguments to a function are not correct"""
pass


class ControlMIMONotImplemented(Exception):
"""Function is not currently implemented for MIMO systems"""
pass


class ControlNotImplemented(Exception):
"""Functionality is not yet implemented"""
pass


# Utility function to see if slycot is installed
def slycot_check():
try:
import slycot
except:
except ImportError as error:
print(error)
return False
except Exception as exception:
print(exception, False)
return False
else:
return True
Loading