Skip to content

BUG: handle git-describe failing to find a tag #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slivingston merged 1 commit into from
Jun 26, 2017
Merged

BUG: handle git-describe failing to find a tag #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions make_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,22 @@

def main():
cmd = 'git describe --always --long'
output = check_output(cmd.split()).decode('utf-8').strip().split('-')
# describe --long usually outputs "tag-numberofcommits-commitname"
output = check_output(cmd.split()).decode('utf-8').strip().rsplit('-',2)
if len(output) == 3:
version, build, commit = output
else:
raise Exception("Could not git describe, (got %s)" % output)
# If the clone is shallow, describe's output won't have tag and
# number of commits. This is a particular issue on Travis-CI,
# which by default clones with a depth of 50.
# This behaviour isn't well documented in git-describe docs,
# but see, e.g., https://stackoverflow.com/a/36389573/1008142
# and https://github.com/travis-ci/travis-ci/issues/3412
version = 'unknown'
build = 'unknown'
# we don't ever expect just one dash from describe --long, but
# just in case:
commit = '-'.join(output)

print("Version: %s" % version)
print("Build: %s" % build)
Expand Down