Fix minreal not returning a discrete TF #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryyorke
reviewed
Mar 29, 2017
Contributor
roryyorke
left a comment
roryyorke
left a comment
There was a problem hiding this comment.
Good spot.
Could you add a test case demonstrating the fix? I think control/tests/xferfcn_test.py would be the place for it.
control/xferfcn.py
Outdated
|
|
||
| # end result | ||
| return TransferFunction(num, den) | ||
| return TransferFunction(num, den, None if self.dt == None else self.dt) |
Contributor
There was a problem hiding this comment.
Couldn't you use self.dt instead of None if self.dt == None else self.dt?
Contributor
Author
There was a problem hiding this comment.
Yea sure :D. Don't know what I was thinking in that moment
1 similar comment
Contributor
|
Looks good to me, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we want to use minreal on a discrete TF the returning TF is continuous and not discrete. This should fix the problem