Repository navigation
Conversation
Member
|
@galleonli Can you run the checks locally yourself, without using OpenAI ? Just confirming as a proof-of-understanding. |
Author
Sure! I ran all four test modules locally myself: 419 passed, 130 skipped. |
slivingston
self-requested a review
November 11, 2026 22:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old tolerance grew with system order, so points where the gain was well below 1 could still count as crossovers. That led to incorrect phase margins.
This change checks the gain again on the unit circle. When a candidate is slightly off, it solves for a nearby root and keeps the point only if the gain is close to 1.
All five new regression cases fail on
mainand pass with this change. The local margin, FRD, transfer-function, and LTI tests finished with 419 passed and 130 skipped.I used OpenAI Codex to write the patch and regression tests and run the local checks.
Refs #1266.