Repository navigation
Fix Nyquist indentation geometry and automatic direction selection - #1265
Closed
dongxuelian2 wants to merge 1 commit into
Closed
dongxuelian2 wants to merge 1 commit into
dongxuelian2 wants to merge 1 commit into
Conversation
Assisted-by: OpenAI Codex
Member
|
@dongxuelian2 Did you write this PR text or did the chat bot entirely write it? |
Member
|
Actually, I am just going to close it, as the AI disclosure implies that the human did nothing at all (not even running validation). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1223 for #1194 and #1191.
The explicit-direction fix still reflects the right-hand offset when indenting left. For example:
On current main this places the contour on the pole and raises
RuntimeError: attempt to evaluate at a pole. The corrected contour starts at -0.15, exactly 0.1 from the pole.This change:
Nonethe automatic mode, preserving the previous default side selection (right of stable/on-axis poles, left of unstable poles);Noneoverride;Regression tests cover continuous/discrete systems, poles at the origin and at nonzero imaginary frequencies, either sign of a tiny real part, distances inside/on/outside the radius, automatic/manual frequency selection, configuration precedence, and the original #1191 transfer function in TF and state-space form. I also reproduced the ignored-direction behavior using the 0.10.2 response code.
Validation (Python 3.13.1, NumPy 2.2.5, SciPy 1.16.1, Matplotlib 3.10.1, Slycot installed):
MPLBACKEND=Agg python -m pytest control/tests/nyquist_test.py control/tests/freqplot_test.py control/tests/response_test.py control/tests/config_test.py control/tests/docstrings_test.py -q: 435 passed, 8 skipped, 1 xfailed.MPLBACKEND=Agg python -m pytest control/tests --ignore=control/tests/optimal_test.py -q --timeout=60: 4577 passed, 51 skipped, 6 xfailed.git diff --checkpassed.The unrestricted suite hit the 60-second timeout in
optimal_test.py::test_optimal_doc, in SciPy optimization/integration; the optimization module was excluded from the broader completed run.AI disclosure: OpenAI Codex generated the implementation, tests, and documentation, investigated and reproduced the bugs, and ran the validation commands. This PR is submitted at the account owner's explicit request.