Repository navigation
FIX: Accept precomputed responses in gangof4_plot - #1261
Closed
huxiaoyi-ovo wants to merge 2 commits into
Closed
huxiaoyi-ovo wants to merge 2 commits into
huxiaoyi-ovo wants to merge 2 commits into
Conversation
huxiaoyi-ovo
marked this pull request as ready for review
October 27, 2026 09:52
Member
|
@huxiaoyi-ovo Can you open an issue first to get agreement that the issues are real? You wrote
so I guess it is not a real issue you encountered but one proposed by a chat bot... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues with
gangof4_plot(response)when passing a precomputed Gang of Four response.Hz=Falsewas incorrectly treated as a frequency override, causing the call to raiseValueError.The fix preserves the existing plant/controller call path and keeps frequency overrides invalid for precomputed responses.
Tests
Added regression tests for:
dB=True.Hz=Falsewhile rejecting frequency overrides (omega,omega_limits,omega_num, andHz=True).Ruff passed. Additional CI checks are running in [fork PR #2](huxiaoyi-ovo#2).
AI assistance: ChatGPT (GPT-6) helped identify the issue, prepare the fix, and add regression tests.