Improve lft functions and lft documentation - #1249
Open
tomaantjes wants to merge 20 commits into
Open
tomaantjes wants to merge 20 commits into
tomaantjes wants to merge 20 commits into
Conversation
…tionality and update reference
update iosys_test test_lft docstring
…ter performing lft
slivingston
self-requested a review
September 15, 2026 00:32
|
coverage: 93.97% (-0.8%) from 94.757% — tomaantjes:improve-lft-functions into python-control:main |
slivingston
requested changes
Sep 15, 2026
slivingston
left a comment
slivingston
left a comment
Member
There was a problem hiding this comment.
Thanks for proposing this. Some tests fail when Slycot is not installed, e.g.,
FAILED control/tests/bdalg_test.py::TestLft::test_lft_tf_inputs[-1--1] - control.exception.ControlMIMONotImplemented: MIMO system conversion not supported without Slycot
FAILED control/tests/bdalg_test.py::TestLft::test_lft_tf_inputs[1-1] - control.exception.ControlMIMONotImplemented: MIMO system conversion not supported without Slycot
Can you fix that? After you do, I will review this pull request.
Author
Of course, I marked it in the newest commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to solve #1156 by updating the current
ss.lftfunction, adding a generallftfunction and adding more documentation.Summary of main changes:
lft(sys1, sys2, [nu, ny], **kwargs)which can be used for anyInputOutputSystemdue to the use ofinterconnectif no statespace conversion is possible.lftfunction.ss.lft()self-contained. Here I added a new reference to a paper as the old one refers to a chapter (A.7) in the second edition of Skogestad which in mine does not discuss LFT's (chapter A.8 is about LFT's but does not contain an explanation of the star product). A reference to the star product does exist in the first edition but I thought this paper was more focused on the topic and also easier to find.lftfunction.lftfunction in appropriate places.AI Disclosure:
Claude was used to proofread and suggest corrections for documentation and verify the documentation and code compliance with the developer standards. Additionally, it was used to assess test coverage and draft some unittests after implementation of the test scaffolding. All suggestions were reviewed, understood and manually tested.